Subject: |
RE: SUP 743 update for Core |
Author: |
Jay Stanley |
Posted: |
2018-07-05 09:01 |
@John, can
ZEN-24565 be made public?
------------------------------
jstanley
------------------------------
Subject: |
RE: SUP 743 update for Core |
Author: |
Jay Stanley |
Posted: |
2018-07-05 09:05 |
Looks like these might be the official patch notes
ZEN-15509 When deleting an organizational group, the devices that belong to that group are not cleanly removed from the group. Subsequently, if the group is recreated, the devices appear in the list of group members, even though the devices claim to not be a member of the group, and the group still claims to have zero members.
ZEN-22773 Modifying mappings will produce audit logging; however, only the changed 'to' value is logged.
ZEN-24034 When a TALES expression is invalid (e.g. referencing an attribute that does not exist), the associated command notification will fail to send.
ZEN-27093 Resource Manager will allow duplicate IPs for devices.
ZEN-27216 ZenHub invalidation workers stop processing.
ZEN-27290 If the infrastructure page is sorted by certain fields (e.g. collector, events) AND a filter to production state is applied, the device list will fail to load and a flare "ProdStateNotSetError" is displayed.
ZEN-27578 RelStorage has been updated to use InnoDB instead of MyISAM engine to improve performance when updating ZODB.
ZEN-27783 Zenossdbpack needs further optimization since it dies with OOM error in large environments
------------------------------
jstanley
------------------------------
Subject: |
RE: SUP 743 update for Core |
Author: |
Thomas Luther |
Posted: |
2018-07-10 01:56 |
Be adviced that SP743 most likely breaks all notifications via Pager or email. I tested an upgrade and zenactiond was flooded with errors like:
ERROR zen.actions: 'skipfails'and on my zenoss master, I got these events:
"/opt/zenoss/Products/ZenModel/actions.py", line 309, in execute self.executeBatch(notification, signal, targets) File "/opt/zenoss/Products/ZenModel/actions.py", line 390, in executeBatch subject = processTalSource(notification.content['clear_subject_format'], notification.content['skipfails'], **data) KeyError: 'skipfails'
I did a roleback of my upgrade, but I suspect that the patch has some flaws regarding notifications.
Running Zenoss Core 4.2.5 on Centos 6
------------------------------
Thomas Luther
Senior Consultant
Netic A/S
------------------------------
Subject: |
RE: SUP 743 update for Core |
Author: |
Jay Stanley |
Posted: |
2018-07-10 07:49 |
Here is a patch I think will fix it
I can't test this on my lab (no old notifications) to see if this fixes it completely, but I was able to mimic the issue using some dmd magic. If you want to test and let me know if this fixes the issue for you, that would be awesome.
https://github.com/jstanley23/zenoss_patches/blob/master/actions_skipfails.patch
------------------------------
jstanley
------------------------------
Subject: |
RE: SUP 743 update for Core |
Author: |
Jane Curry |
Posted: |
2018-07-11 12:45 |
I have to say that SUP743 has not (so far) broken my notifications - but i can see that Jay's code is safer so will implement.
Zenoss -
@John - since Jay has now provided 2 patches, one for each of SUP 732 and 743, both of which are obviously complete showstoppers to some users, - may we ask that Zenoss provides another "last maintenance SUP" for Core that at least includes these two?
Thanks,
Jane
------------------------------
Jane Curry
Skills 1st United Kingdom
jane.curry@skills-1st.co.uk
------------------------------
Subject: |
RE: SUP 743 update for Core |
Author: |
Thomas Luther |
Posted: |
2018-07-18 06:53 |
Hey Jay
I have now had a chance to test this on our dev-setup, and I can reproduce the error and can then verify that your patch fixes the issue.
It appears that the problem is only with Page notifications. My mail-notifications did come through even without the patch. But setting up a Page notification, then I had the skipfails error in zenactiond.log.
------------------------------
Thomas Luther
Senior Consultant
Netic A/S
------------------------------