TECHZEN Zenoss User Community ARCHIVE  
FORUMS / Legacy Discussions / DISCUSSION

ZEN-14666 within SP457 breaks DeviceSearch

Subject: ZEN-14666 within SP457 breaks DeviceSearch
Author: Charles Bueche
Posted: 2015-05-28 10:25

Hi,

I'm running Zenoss Core 4.2.5 on CentOS 6. I applied the SP457 ZUP to fix a few issues I do have. I have noticed it breaks the DeviceSearch, probably through ZEN-14666, with the following error popup :

TypeError: getSearchResults() got an unexpected keyword argument 'maxResults'

I think the problem is in $ZENHOME/Products/Zuul/search/facades.py :
I'm not sure how to fix this correctly because I do not really took the time to understand that adapter stuff and the difference between getSearchResults and getQuickSearchResults. Still, this small patch seems to fix my problem.

Or is there something I have overlooked

TIA,
Charles

P.S. oh boy this web-editor is so broken.

Subject: First off: sorry about the
Author: Andrew Kirch
Posted: 2015-05-28 10:34

First off: sorry about the web editor, it's in the process of being upgraded.

Second, please submit a bug on jira.zenoss.com noting hte specific patch htat broke it. Mark it as a P1 regression.

Andrew Kirch

akirch@gvit.com

Need Zenoss support, consulting or custom development Look no further. Email or PM me!

Ready for Distributed Topology (collectors) for Zenoss 5 Coming May 1st from GoVanguard


Subject: Thanks Andrew, reported as
Author: Charles Bueche
Posted: 2015-05-29 01:53

Thanks Andrew, reported as https://jira.zenoss.com/browse/ZEN-18076


Subject: FIXED: ZEN-14666 within SP457 breaks DeviceSearch
Author: Charles Bueche
Posted: 2015-06-12 08:44

the correct fix is https://github.com/zenoss/ZenPacks.zenoss.DeviceSearch/pull/1/files


Subject: How can the fix be applied? I
Author: Joan
Posted: 2015-09-16 08:58

How can the fix be applied I modified the file according the change in the patch, but still I get the same error. I tried also removing the pyc file, (so it can be recompiled), but it gets recreated but still failing.
At the end I did the 'zenoss restart' and worked fine, but it's non-convenient because it takes some minutes to complete.


Subject: - download the patch from
Author: Charles Bueche
Posted: 2015-09-16 09:09

- download the patch from github, or create a patch file by copy-pasting the code into a file
- go to the correct directory, for me, it was $ZENHOME/ZenPacks/ZenPacks.zenoss.DeviceSearch-1.2.0-py2.7.egg/ZenPacks/zenoss/DeviceSearch/device
- save your adapters.py file
- use "patch" : patch < your_patch.file, see http://jungels.net/articles/diff-patch-ten-minutes.html
- restart zenoss (probably restarting only the correct daemon would do the job, but I didn't try to find out what exact daemon needs to be restarted)



< Previous
Problem upgrade to 5.0.3 		  Next
twisted.internet.error.ConnectionLost 		>